LAG: Accept user specified lag.ifindex, also when listed in descending order #2248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one looks a bit fishy. Have to check what happens if you have three LAGs and you number then "2, 1, none". Will merge after 2.0.0 goes out. |
That would assign overlapping ifindex values. The code is not currently trying to be overly sophisticated about auto-assigning missing ifindex values - it would mean keeping track of a set per node. Could be added We could also change it such that the user has to specify all |
ipspace
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2246
Tested:
./device-module-test -d eos -p clab lag